kern/9406: /boot/loader is always overwritten on install

From:	dcs@newsguy.com
Date:	Sun, 10 Jan 1999 05:54:41 +0900 (JST)
Subject:	old loader ought to be preserved on install
Send-pr version:	3.2

Number:	9406
Category:	kern
Synopsis:	/boot/loader is always overwritten on install
Severity:	non-critical
Priority:	low
Responsible:	freebsd-bugs@FreeBSD.org
State:	closed
Class:	change-request
Arrival-Date:	Sat Jan 9 13:00:01 PST 1999
Closed-Date:	Mon Feb 8 13:34:00 PST 1999
Last-Modified:	Mon Feb 8 13:35:06 PST 1999
Originator:	Daniel C. Sobral
Release:	FreeBSD 3.0-CURRENT i386

Organization:

Environment:

Three stage boot loader installation.

Description:

make install on sys/boot will always overwrite /boot/loader. The
new loader might not be as critical as a kernel, but it would still be
a help saving it just in case.

How-To-Repeat:

cd /sys/boot
make install

Fix:

Apply the following patch:

Download patch-1.diff

--- sys/boot/i386/loader/Makefile.orig   Sun Jan 10 05:43:16 1999
+++ sys/boot/i386/loader/Makefile        Sun Jan 10 05:49:11 1999
@@ -80,6 +80,9 @@
         perl ${.CURDIR}/../../common/merge_help.pl ${.ALLSRC} > ${.TARGET}
 beforeinstall:
+.if exists(${DESTDIR}/boot/loader)
+        mv ${DESTDIR}/boot/loader ${DESTDIR}/boot/loader.old
+.endif
 .if exists(${.OBJDIR}/loader.help)
         ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \
                 ${.OBJDIR}/${BASE}.help ${DESTDIR}/boot

Release-Note:

Audit-Trail:

State Changed
From-To:	open->closed
By:	dcs
When:	Mon Feb 8 13:34:00 PST 1999
Why:	This has already been fixed.

Unformatted:

Submit Followup | Raw PR | Find another PR