Ext event (function) | Need attention from locking point of view | Comment |
sppp_modevent | No | Almos null function. |
sppp_input | Yes | Usually called from interrupt handler. Probably we should acquire lock a bit later. |
sppp_output | Yes | Spl realisation releases lock here beofre call to lcp.Open. I wonder why? We need to protect state machine here. |
sppp_attach | No | The only thing that may require locking is sppp_keepalive timer. But even if it will run before end of attach, it would just reset callout since !IFF_RUNNING and !PP_KEEPALIVE |
sppp_detach | No | It just nukes callouts and timeouts. |
sppp_flush | Yes | Need some special attention cause it called from within sppp it self. |
sppp_isempty | Yes | Protects queues while quering, just like spl did. |
sppp_dequeue | Yes | Protects queues, just like spl did. |
sppp_pick | Yes | Protects queues, like spl did. This should be revised some how, since we couldn't give any guarantee that queue wouldn't change after we leave this function. |
sppp_ioctl | Yes | Like spl did. |
sppp_lcp_up | N/A yet | |
sppp_lcp_down | N/A yet | |
sppp_lcp_TO | Yes | Timer, sppp_to_event, like spl did. |
sppp_ipcp_TO | Yes | Timer, sppp_to_event, like spl did. |
sppp_ipv6cp_TO | Yes | Timer, sppp_to_event, like spl did. |
sppp_pap_TO | Yes | Timer, like spl did. |
sppp_pap_my_TO | Yes | Timer |
sppp_chap_TO | Yes | Timer, like spl did. |
sppp_keepalive | Yes | Timer, like spl did |
2004-06-04 Rober Watson patch (06-03) fixed relative recent changes