Index: su.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/su/su.c,v
retrieving revision 1.68
diff -u -p -r1.68 su.c
--- su.c	8 Apr 2003 16:59:53 -0000	1.68
+++ su.c	4 Jul 2003 01:12:34 -0000
@@ -520,10 +520,8 @@ chshell(char *sh)
 
 	r = 0;
 	setusershell();
-	do {
-		cp = getusershell();
-		r = strcmp(cp, sh);
-	} while (!r && cp != NULL);
+	while ((cp = getusershell()) != NULL && !r)
+	    r = (strcmp(cp, sh) == 0);
 	endusershell();
 	return r;
 }