--- src/backend/utils/adt/ri_triggers.c.orig Thu Oct 3 14:06:23 2002 +++ src/backend/utils/adt/ri_triggers.c Sat Apr 26 15:54:48 2003 @@ -56,17 +56,18 @@ #define RI_KEYS_SOME_NULL 1 #define RI_KEYS_NONE_NULL 2 - +/* queryno values must be distinct for the convenience of ri_PerformCheck */ #define RI_PLAN_CHECK_LOOKUPPK_NOCOLS 1 #define RI_PLAN_CHECK_LOOKUPPK 2 -#define RI_PLAN_CASCADE_DEL_DODELETE 1 -#define RI_PLAN_CASCADE_UPD_DOUPDATE 1 -#define RI_PLAN_NOACTION_DEL_CHECKREF 1 -#define RI_PLAN_NOACTION_UPD_CHECKREF 1 -#define RI_PLAN_RESTRICT_DEL_CHECKREF 1 -#define RI_PLAN_RESTRICT_UPD_CHECKREF 1 -#define RI_PLAN_SETNULL_DEL_DOUPDATE 1 -#define RI_PLAN_SETNULL_UPD_DOUPDATE 1 +#define RI_PLAN_CASCADE_DEL_DODELETE 3 +#define RI_PLAN_CASCADE_UPD_DOUPDATE 4 +#define RI_PLAN_NOACTION_DEL_CHECKREF 5 +#define RI_PLAN_NOACTION_UPD_CHECKREF 6 +#define RI_PLAN_RESTRICT_DEL_CHECKREF 7 +#define RI_PLAN_RESTRICT_UPD_CHECKREF 8 +#define RI_PLAN_SETNULL_DEL_DOUPDATE 9 +#define RI_PLAN_SETNULL_UPD_DOUPDATE 10 +#define RI_PLAN_KEYEQUAL_UPD 11 #define MAX_QUOTED_NAME_LEN (NAMEDATALEN*2+3) #define MAX_QUOTED_REL_NAME_LEN (MAX_QUOTED_NAME_LEN*2) @@ -147,6 +148,10 @@ static void ri_InitHashTables(void); static void *ri_FetchPreparedPlan(RI_QueryKey *key); static void ri_HashPreparedPlan(RI_QueryKey *key, void *plan); +static void *ri_PlanCheck(char *querystr, int nargs, Oid *argtypes, + RI_QueryKey *qkey, Relation fk_rel, Relation pk_rel, + bool cache_plan); + /* ---------- * RI_FKey_check - @@ -262,6 +267,9 @@ fk_rel, pk_rel, tgnargs, tgargs); + if (SPI_connect() != SPI_OK_CONNECT) + elog(ERROR, "SPI_connect() failed in RI_FKey_check()"); + if ((qplan = ri_FetchPreparedPlan(&qkey)) == NULL) { char querystr[MAX_QUOTED_REL_NAME_LEN + 100]; @@ -276,20 +284,14 @@ snprintf(querystr, sizeof(querystr), "SELECT 1 FROM ONLY %s x FOR UPDATE OF x", pkrelname); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, 0, NULL); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, 0, NULL, + &qkey, fk_rel, pk_rel, true); } /* * Execute the plan */ - if (SPI_connect() != SPI_OK_CONNECT) - elog(WARNING, "SPI_connect() failed in RI_FKey_check()"); - SetUserId(RelationGetForm(pk_rel)->relowner); if (SPI_execp(qplan, check_values, check_nulls, 1) != SPI_OK_SELECT) @@ -418,7 +420,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE pkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding FK attributes. Thus, SPI_prepare could + * corresponding FK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -438,12 +440,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -623,7 +622,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE pkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding FK attributes. Thus, SPI_prepare could + * corresponding FK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -643,12 +642,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, pk_rel, pk_rel, true); } /* @@ -832,7 +828,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -852,12 +848,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -1073,7 +1066,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -1093,12 +1086,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -1286,7 +1276,7 @@ * The query string built is * DELETE FROM ONLY WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -1305,12 +1295,9 @@ qkey.keypair[i][RI_KEYPAIR_PK_IDX]); } - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -1509,7 +1496,7 @@ * UPDATE ONLY SET fkatt1 = $1 [, ...] * WHERE fkatt1 = $n [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -1535,12 +1522,9 @@ } strcat(querystr, qualstr); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs * 2, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs * 2, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -1739,7 +1723,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -1759,12 +1743,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -1973,7 +1954,7 @@ * The query string built is * SELECT 1 FROM ONLY WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -1993,12 +1974,9 @@ } strcat(querystr, " FOR UPDATE OF x"); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -2193,7 +2171,7 @@ * UPDATE ONLY SET fkatt1 = NULL [, ...] * WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -2218,12 +2196,9 @@ } strcat(querystr, qualstr); - /* - * Prepare, save and remember the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); + /* Prepare and save the plan */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, true); } /* @@ -2443,7 +2418,7 @@ * UPDATE ONLY SET fkatt1 = NULL [, ...] * WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -2479,19 +2454,12 @@ strcat(querystr, qualstr); /* - * Prepare the new plan. - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); - - /* - * Save and remember the plan if we're building the + * Prepare the plan. Save it only if we're building the * "standard" plan. */ - if (use_cached_query) - { - qplan = SPI_saveplan(qplan); - ri_HashPreparedPlan(&qkey, qplan); - } + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, + use_cached_query); } /* @@ -2682,7 +2650,7 @@ * UPDATE ONLY SET fkatt1 = NULL [, ...] * WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -2707,10 +2675,10 @@ } strcat(querystr, qualstr); - /* - * Prepare the plan - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); + /* Prepare the plan, don't save it */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, false); + /* ---------- * Here now follows very ugly code depending on internals @@ -2957,7 +2925,7 @@ * UPDATE ONLY SET fkatt1 = NULL [, ...] * WHERE fkatt1 = $1 [AND ...] * The type id's for the $ parameters are those of the - * corresponding PK attributes. Thus, SPI_prepare could + * corresponding PK attributes. Thus, ri_PlanCheck could * eventually fail if the parser cannot identify some way * how to compare these two types by '='. * ---------- @@ -2992,10 +2960,9 @@ } strcat(querystr, qualstr); - /* - * Prepare the plan - */ - qplan = SPI_prepare(querystr, qkey.nkeypairs, queryoids); + /* Prepare the plan, don't save it */ + qplan = ri_PlanCheck(querystr, qkey.nkeypairs, queryoids, + &qkey, fk_rel, pk_rel, false); /* * Now replace the CONST NULL targetlist expressions in @@ -3158,7 +3125,7 @@ case RI_MATCH_TYPE_UNSPECIFIED: case RI_MATCH_TYPE_FULL: ri_BuildQueryKeyFull(&qkey, trigdata->tg_trigger->tgoid, - 0, + RI_PLAN_KEYEQUAL_UPD, fk_rel, pk_rel, tgnargs, tgargs); @@ -3194,6 +3161,52 @@ * ---------- */ + +/* + * Prepare execution plan for a query to enforce an RI restriction + * + * If cache_plan is true, the plan is saved into our plan hashtable + * so that we don't need to plan it again. + */ +static void * +ri_PlanCheck(char *querystr, int nargs, Oid *argtypes, + RI_QueryKey *qkey, Relation fk_rel, Relation pk_rel, + bool cache_plan) +{ + void *qplan; + Relation query_rel; + Oid save_uid; + + /* + * The query is always run against the FK table except + * when this is an update/insert trigger on the FK table itself - + * either RI_PLAN_CHECK_LOOKUPPK or RI_PLAN_CHECK_LOOKUPPK_NOCOLS + */ + if (qkey->constr_queryno == RI_PLAN_CHECK_LOOKUPPK || + qkey->constr_queryno == RI_PLAN_CHECK_LOOKUPPK_NOCOLS) + query_rel = pk_rel; + else + query_rel = fk_rel; + + /* Switch to proper UID to perform check as */ + save_uid = GetUserId(); + SetUserId(RelationGetForm(query_rel)->relowner); + + /* Create the plan */ + qplan = SPI_prepare(querystr, nargs, argtypes); + + /* Restore UID */ + SetUserId(save_uid); + + /* Save the plan if requested */ + if (cache_plan) + { + qplan = SPI_saveplan(qplan); + ri_HashPreparedPlan(qkey, qplan); + } + + return qplan; +} /* * quoteOneName --- safely quote a single SQL name